Conversation
farzonl
added
the
test-all
|
Also some of the tests seem to fail because there isn't an |
Sorry will do a review of this in the morning. But yeah xfail for clang for now |
kmpeng
left a comment
kmpeng
left a comment
There was a problem hiding this comment.
You should take [Matrix] out of the title since this PR is covering more than just the matrix tests.
kmpeng
left a comment
kmpeng
left a comment
There was a problem hiding this comment.
The structure of the tests lgtm, but I have some problems with the values being used. I'm also not very familiar with matrices, so I'll defer to other people for more feedback on those (@farzonl ?)
FYI a lot of the failing checks on this PR have been fixed recently. Could you update the branch so it's easier to see the ones this PR is affecting?
|
Sorry was a little busy today, will get to this tomorrow |
…es as in constant folding
kmpeng
left a comment
kmpeng
left a comment
There was a problem hiding this comment.
LGTM, but again you should probably get more feedback on the matrix test
|
Could you maybe ping someone who is working with matrices then? I would be really grateful. |
|
@NeKon69 This should be ready to go. Do you need someone to merge it in for you? You should probably also update the branch to make sure nothing has broken as it's been a while |
|
Yes I need someone to merge this for me, just updated the branch |
6 participants
This PR adds double tests for
fmafunction. Only double is applicable to this function as per official apiCloses #916
Related to llvm/llvm-project/#185304
Assisted-by: GPT-5.4 (opencode)